feat: Add retry and validation logic to Redis cluster operations #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naimadswdn
requested review from
drivebyer,
iamabhishek-dubey and
shubham-cmyk
as code owners
naimadswdn
force-pushed
the
feat/improve-redis-operations
branch
from
e2c0b8c to
083a1b8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
=======================================
Coverage ? 30.82%
=======================================
Files ? 78
Lines ? 6069
Branches ? 0
=======================================
Hits ? 1871
Misses ? 4005
Partials ? 193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
naimadswdn
force-pushed
the
feat/improve-redis-operations
branch
2 times, most recently
from
d06208c to
5cf71c8
Compare
- Add validateClusterBalance() to verify slot distribution - Implement retry logic for RebalanceRedisCluster functions - Dynamically select healthy leader node for operations - Validate cluster state after rebalance operations - Return structured errors with context Signed-off-by: Damian Seredyn <[email protected]>
drivebyer
force-pushed
the
feat/improve-redis-operations
branch
from
5cf71c8 to
2ba8ab2
Compare
Contributor
Author
|
@drivebyer how about merge? 💯 |
Collaborator
IMO, this PR doesn’t fix an obviously existing issue and also introduces code complexity. We should hold off on it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist
Additional Context
Motivated by frequent E2E tests failures related to Redis Cluster setup.